From afaaf623d4d95b3ac736e72c744f683a2b804e1d Mon Sep 17 00:00:00 2001 From: Adam Jackson Date: Wed, 14 Sep 2016 14:02:56 -0400 Subject: [PATCH] glx/glvnd: Use bsearch() in FindGLXFunction instead of open-coding it Reviewed-by: Eric Engestrom Signed-off-by: Adam Jackson --- src/glx/glxglvnd.c | 30 ++++++++++++++---------------- 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/src/glx/glxglvnd.c b/src/glx/glxglvnd.c index 2fc9b0080f8..b6b415114c9 100644 --- a/src/glx/glxglvnd.c +++ b/src/glx/glxglvnd.c @@ -1,11 +1,11 @@ #include +#include #include #include "glvnd/libglxabi.h" #include "glxglvnd.h" - static Bool __glXGLVNDIsScreenSupported(Display *dpy, int screen) { /* TODO: Think of a better heuristic... */ @@ -17,26 +17,24 @@ static void *__glXGLVNDGetProcAddress(const GLubyte *procName) return glXGetProcAddressARB(procName); } +static int +compare(const void *l, const void *r) +{ + const char *s = *(const char **)r; + return strcmp(l, s); +} + static unsigned FindGLXFunction(const GLubyte *name) { - int first = 0; - int last = DI_FUNCTION_COUNT - 1; + const char **match; - while (first <= last) { - int middle = (first + last) / 2; - int comp = strcmp(__glXDispatchTableStrings[middle], - (const char *) name); + match = bsearch(name, __glXDispatchTableStrings, DI_FUNCTION_COUNT, + sizeof(const char *), compare); - if (comp < 0) - first = middle + 1; - else if (comp > 0) - last = middle - 1; - else - return middle; - } + if (match == NULL) + return DI_FUNCTION_COUNT; - /* Just point to the dummy entry at the end of the respective table */ - return DI_FUNCTION_COUNT; + return match - __glXDispatchTableStrings; } static void *__glXGLVNDGetDispatchAddress(const GLubyte *procName)