freedreno/ir3: check the type of regs of absneg opcode in is_same_type_mov.

If the type of dest reg and src reg of absneg opcode are different,
it shouldn't be considered as same type mov.

This patch becomes meaningful when we start to use mediump information for
doing precision lowering to 16bit.

Signed-off-by: Rob Clark <robdclark@chromium.org>
This commit is contained in:
Hyunjun Ko 2019-04-15 03:42:23 +00:00 committed by Rob Clark
parent 6fb8ef3da6
commit a9b556d3a0
1 changed files with 16 additions and 0 deletions

View File

@ -614,6 +614,18 @@ static inline bool is_nop(struct ir3_instruction *instr)
return instr->opc == OPC_NOP;
}
static inline bool is_same_type_reg(struct ir3_register *reg1,
struct ir3_register *reg2)
{
unsigned type_reg1 = (reg1->flags & (IR3_REG_HIGH | IR3_REG_HALF));
unsigned type_reg2 = (reg1->flags & (IR3_REG_HIGH | IR3_REG_HALF));
if (type_reg1 ^ type_reg2)
return false;
else
return true;
}
/* Is it a non-transformative (ie. not type changing) mov? This can
* also include absneg.s/absneg.f, which for the most part can be
* treated as a mov (single src argument).
@ -631,6 +643,10 @@ static inline bool is_same_type_mov(struct ir3_instruction *instr)
case OPC_ABSNEG_S:
if (instr->flags & IR3_INSTR_SAT)
return false;
/* If the type of dest reg and src reg are different,
* it shouldn't be considered as same type mov */
if (!is_same_type_reg(instr->regs[0], instr->regs[1]))
return false;
break;
default:
return false;