KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pan/mdg: emit REGISTER_UNUSED on unused ALU src2 

This saves power and time by skipping a roundtrip to the register file.

Signed-off-by: Italo Nicola <italonicola@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6128>
This commit is contained in:
Italo Nicola 2020-07-30 23:24:06 +00:00 committed by Marge Bot
parent a2065917cc
commit a91011c9ec
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/panfrost/midgard/helpers.h
View File

@ -143,6 +143,9 @@
/* Uniforms are begin at (REGISTER_UNIFORMS - uniform_count) */
#define REGISTER_UNIFORMS 24
/* r24 and r25 are special registers that only exist during the pipeline,
* by using them when we don't care about the register we skip a roundtrip
* to the register file. */
#define REGISTER_UNUSED 24
#define REGISTER_CONSTANT 26
#define REGISTER_LDST_BASE 26

10
src/panfrost/midgard/midgard_emit.c
View File

@ -736,15 +736,19 @@ emit_alu_bundle(compiler_context *ctx,
/* Check if this instruction has registers */
if (ins->compact_branch) continue;
unsigned src2_reg = REGISTER_UNUSED;
if (ins->has_inline_constant)
src2_reg = ins->inline_constant >> 11;
else if (ins->src[1] != ~0)
src2_reg = SSA_REG_FROM_FIXED(ins->src[1]);
/* Otherwise, just emit the registers */
uint16_t reg_word = 0;
midgard_reg_info registers = {
.src1_reg = (ins->src[0] == ~0 ?
REGISTER_UNUSED :
SSA_REG_FROM_FIXED(ins->src[0])),
.src2_reg = (ins->src[1] == ~0 ?
ins->inline_constant >> 11 :
SSA_REG_FROM_FIXED(ins->src[1])),
.src2_reg = src2_reg,
.src2_imm = ins->has_inline_constant,
.out_reg = (ins->dest == ~0 ?
REGISTER_UNUSED :