KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pan/bi: Fix typo. 

Fix defect reported by Coverity Scan.

Same on both sides (CONSTANT_EXPRESSION_RESULT)
pointless_expression: The expression src0_u8 || src0_u8 does not
accomplish anything because it evaluates to either of its
identical operands, src0_u8.

Fixes: 2ff53879f2 ("pan/bi: Use new packing")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6780>
This commit is contained in:
Vinson Lee 2020-09-18 15:21:14 -07:00
parent ade72e677b
commit a5967f308c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/panfrost/bifrost/bi_pack.c
View File

@ -698,7 +698,7 @@ bi_pack_add(bi_clause *clause, bi_bundle bundle, bi_registers *regs, gl_shader_s
return pan_pack_add_icmp_i32(clause, bundle.add, regs);
else if ((src0_u16 || src0_s16) && typeless_cond)
return pan_pack_add_icmp_v2i16(clause, bundle.add, regs);
else if ((src0_u8 || src0_u8) && typeless_cond)
else if ((src0_u8 || src0_s8) && typeless_cond)
return pan_pack_add_icmp_v4i8(clause, bundle.add, regs);
else if (src0_u32)
return pan_pack_add_icmp_u32(clause, bundle.add, regs);