From a24d6fbae60c01a39fe5a026fb568ab7facc6fbb Mon Sep 17 00:00:00 2001 From: Dylan Baker Date: Thu, 21 Nov 2019 09:11:45 -0800 Subject: [PATCH] meson: Add -Werror=gnu-empty-initializer to MSVC compat args Only clang has this argument (at least as of clang 8 and gcc 9), which errors when using the gcc empty initializer syntax in C: ```C struct foo f = {}; ``` GCC has a warning for this, but only when using -Wpedantic, which is a lot of noise to lose useful warnings in. Reviewed-by: Kristian H. Kristensen Reviewed-by: Eric Engestrom --- meson.build | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/meson.build b/meson.build index e8bec9bb389..92e45d28640 100644 --- a/meson.build +++ b/meson.build @@ -996,10 +996,10 @@ else c_vis_args += '-fvisibility=hidden' endif - # Check for C and C++ arguments for MSVC2013 compatibility. These are only - # used in parts of the mesa code base that need to compile with old versions - # of MSVC, mainly common code - foreach a : ['-Werror=pointer-arith', '-Werror=vla'] + # Check for C and C++ arguments for MSVC compatibility. These are only used + # in parts of the mesa code base that need to compile with MSVC, mainly + # common code + foreach a : ['-Werror=pointer-arith', '-Werror=vla', '-Werror=gnu-empty-initializer'] if cc.has_argument(a) c_msvc_compat_args += a endif