scons: wait on subprocess' completion
Windows doesn't allow you to move a file that's opened, and Popen()
doesn't wait on its subprocess' completion before returning, which leads
to broken Windows build.
Fixes: 3fd425aed7
"build systems: uniformize git_sha1.h generation"
Suggested-by: Scott D Phillips <scott.d.phillips@intel.com>
Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
This commit is contained in:
parent
3fd425aed7
commit
9f6110ad32
|
@ -26,7 +26,7 @@ def write_git_sha1_h_file(filename):
|
|||
with open(tempfile, "w") as f:
|
||||
args = [ 'sh', Dir('#').abspath + '/git_sha1_gen.sh' ]
|
||||
try:
|
||||
subprocess.Popen(args, stdout=f)
|
||||
subprocess.Popen(args, stdout=f).wait()
|
||||
except:
|
||||
print "Warning: exception in write_git_sha1_h_file()"
|
||||
return
|
||||
|
|
Loading…
Reference in New Issue