From 9e31991c6e44fa65eea3f226ddebb46fff6b6eaf Mon Sep 17 00:00:00 2001 From: Jakob Bornecrantz Date: Sun, 27 Mar 2022 16:00:22 +0100 Subject: [PATCH] vulkan-device-select: Don't leak xcb_query_extension_reply_t Part-of: --- src/vulkan/device-select-layer/device_select_x11.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/vulkan/device-select-layer/device_select_x11.c b/src/vulkan/device-select-layer/device_select_x11.c index 17387514abf..dbfd622cd78 100644 --- a/src/vulkan/device-select-layer/device_select_x11.c +++ b/src/vulkan/device-select-layer/device_select_x11.c @@ -74,7 +74,7 @@ int device_select_find_xcb_pci_default(struct device_pci_info *devices, uint32_t return -1; xcb_query_extension_cookie_t dri3_cookie; - xcb_query_extension_reply_t *dri3_reply; + xcb_query_extension_reply_t *dri3_reply = NULL; dri3_cookie = xcb_query_extension(conn, 4, "DRI3"); dri3_reply = xcb_query_extension_reply(conn, dri3_cookie, NULL); @@ -84,6 +84,7 @@ int device_select_find_xcb_pci_default(struct device_pci_info *devices, uint32_t if (dri3_reply->present == 0) goto out; + setup = xcb_get_setup(conn); iter = xcb_setup_roots_iterator(setup); @@ -116,6 +117,7 @@ int device_select_find_xcb_pci_default(struct device_pci_info *devices, uint32_t } out: + free(dri3_reply); drmFreeDevice(&xdev); /* Is NULL pointer safe. */ xcb_disconnect(conn); return default_idx;