KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nir: Try to warn when C99 extensions are used in nir headers. 

Ideally we'd have nir.h being included with -Wpedantic too, but it fails
with:

src/compiler/nir/nir.h:754:20: warning: ISO C++ forbids zero-size array ‘src’ [-Wpedantic]
    nir_alu_src src[];
                    ^
In file included from src/compiler/nir/glsl_to_nir.cpp:42:0:
src/compiler/nir/nir.h:919:16: warning: ISO C++ forbids zero-size array ‘src’ [-Wpedantic]
    nir_src src[];

Reviewed-by: Connor Abbott <cwabbott0@gmail.com>
This commit is contained in:
Jose Fonseca 2016-04-28 12:25:15 +01:00
parent e7438009af
commit 99474dc29b
1 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/compiler/nir/glsl_to_nir.cpp
View File

@ -25,9 +25,30 @@
*
*/
#include "glsl_to_nir.h"
#include "nir.h"
/*
* Have GCC/Clang warn when NIR headers use C99 extensions that are not
* supported in C++, as they are not portable. In particular MSVC does not
* support C99 structure field initializers.
*/
#if defined(__GNUC__)
# pragma GCC diagnostic push
# if defined(__clang__)
# pragma GCC diagnostic warning "-Wc99-extensions"
# else
# pragma GCC diagnostic warning "-Wpedantic"
# endif
#endif
#include "nir_control_flow.h"
#include "nir_builder.h"
#if defined(__GNUC__)
# pragma GCC diagnostic pop
#endif
#include "glsl_to_nir.h"
#include "compiler/glsl/ir_visitor.h"
#include "compiler/glsl/ir_hierarchical_visitor.h"
#include "compiler/glsl/ir.h"