panfrost: Remove minimal mode
Superseded by abort-on-fault. It didn't work correctly in the presence of MMU faults anyway. Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10938>
This commit is contained in:
parent
2f4b5a4ebe
commit
95337edcd7
|
@ -893,7 +893,7 @@ panfrost_batch_submit_ioctl(struct panfrost_batch *batch,
|
|||
INT64_MAX, 0, NULL);
|
||||
|
||||
if (dev->debug & PAN_DBG_TRACE)
|
||||
pandecode_jc(submit.jc, pan_is_bifrost(dev), dev->gpu_id, false);
|
||||
pandecode_jc(submit.jc, pan_is_bifrost(dev), dev->gpu_id);
|
||||
|
||||
if (dev->debug & PAN_DBG_SYNC)
|
||||
pandecode_abort_on_fault(submit.jc);
|
||||
|
|
|
@ -1080,13 +1080,10 @@ pandecode_write_value_job(const struct pandecode_mapped_memory *mem,
|
|||
* in the chain; later jobs are found by walking the chain. Bifrost is, well,
|
||||
* if it's bifrost or not. GPU ID is the more finegrained ID (at some point, we
|
||||
* might wish to combine this with the bifrost parameter) because some details
|
||||
* are model-specific even within a particular architecture. Minimal traces
|
||||
* *only* examine the job descriptors, skipping printing entirely if there is
|
||||
* no faults, and only descends into the payload if there are faults. This is
|
||||
* useful for looking for faults without the overhead of invasive traces. */
|
||||
* are model-specific even within a particular architecture. */
|
||||
|
||||
void
|
||||
pandecode_jc(mali_ptr jc_gpu_va, bool bifrost, unsigned gpu_id, bool minimal)
|
||||
pandecode_jc(mali_ptr jc_gpu_va, bool bifrost, unsigned gpu_id)
|
||||
{
|
||||
pandecode_dump_file_open();
|
||||
|
||||
|
@ -1103,10 +1100,6 @@ pandecode_jc(mali_ptr jc_gpu_va, bool bifrost, unsigned gpu_id, bool minimal)
|
|||
|
||||
int job_no = job_descriptor_number++;
|
||||
|
||||
/* If the job is good to go, skip it in minimal mode */
|
||||
if (minimal && (h.exception_status == 0x0 || h.exception_status == 0x1))
|
||||
continue;
|
||||
|
||||
DUMP_UNPACKED(JOB_HEADER, h, "Job Header:\n");
|
||||
pandecode_log("\n");
|
||||
|
||||
|
|
|
@ -53,7 +53,7 @@ pandecode_inject_mmap(uint64_t gpu_va, void *cpu, unsigned sz, const char *name)
|
|||
|
||||
void pandecode_inject_free(uint64_t gpu_va, unsigned sz);
|
||||
|
||||
void pandecode_jc(uint64_t jc_gpu_va, bool bifrost, unsigned gpu_id, bool minimal);
|
||||
void pandecode_jc(uint64_t jc_gpu_va, bool bifrost, unsigned gpu_id);
|
||||
|
||||
void
|
||||
pandecode_abort_on_fault(uint64_t jc_gpu_va);
|
||||
|
|
Loading…
Reference in New Issue