From 9279ed1550bfcfe5e12b618d1b73289a51baf24b Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Mon, 6 Apr 2020 14:13:13 -0400 Subject: [PATCH] pan/bi: Fix incorrect abs flip in fma/fadd16 Signed-off-by: Alyssa Rosenzweig Part-of: --- src/panfrost/bifrost/bi_pack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/panfrost/bifrost/bi_pack.c b/src/panfrost/bifrost/bi_pack.c index 99a0077d1ae..89eab4fa04f 100644 --- a/src/panfrost/bifrost/bi_pack.c +++ b/src/panfrost/bifrost/bi_pack.c @@ -591,8 +591,8 @@ bi_pack_fma_addmin_f16(bi_instruction *ins, struct bi_registers *regs) bool flip = false; if (!abs_0 && !abs_1) { - /* Force k = 0 <===> NOT(src1 < src0) <==> src1 >= src0 */ - flip = (src_0 < src_1); + /* Force k = 0 <===> NOT(src1 < src0) */ + flip = (src_1 < src_0); } else if (abs_0 && !abs_1) { l = src_1 >= src_0; } else if (abs_1 && !abs_0) {