KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

v3dv: Remove unsigned comparison to zero. 

subpass_idx is of type uint32_t.

Fix defects reported by Coverity Scan.

Macro compares unsigned to 0 (NO_EFFECT)
unsigned_compare: This greater-than-or-equal-to-zero comparison of
an unsigned value is always true. subpass_idx >= 0U.

Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7325>
This commit is contained in:
Vinson Lee 2020-10-26 19:43:44 -07:00 committed by Marge Bot
parent 03683b9b2e
commit 923577c066
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/broadcom/vulkan/v3dv_pass.c
View File

@ -273,7 +273,7 @@ subpass_get_granularity(struct v3dv_render_pass *pass,
/* Our tile size depends on the number of color attachments and the maximum
* bpp across them.
*/
assert(subpass_idx >= 0 && subpass_idx < pass->subpass_count);
assert(subpass_idx < pass->subpass_count);
struct v3dv_subpass *subpass = &pass->subpasses[subpass_idx];
const uint32_t color_attachment_count = subpass->color_count;
@ -354,7 +354,7 @@ v3dv_subpass_area_is_tile_aligned(const VkRect2D *area,
struct v3dv_render_pass *pass,
uint32_t subpass_idx)
{
assert(subpass_idx >= 0 && subpass_idx < pass->subpass_count);
assert(subpass_idx < pass->subpass_count);
VkExtent2D granularity;
subpass_get_granularity(pass, subpass_idx, &granularity);