draw: Clean up single-use goto statements.

Suggested-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7389>
This commit is contained in:
Vinson Lee 2020-10-30 19:29:39 -07:00 committed by Marge Bot
parent e9caba6ce5
commit 904dcfd914
1 changed files with 10 additions and 19 deletions

View File

@ -308,16 +308,11 @@ generate_aaline_fs(struct aaline_stage *aaline)
#endif
aaline->fs->aaline_fs = aaline->driver_create_fs_state(pipe, &aaline_fs);
if (aaline->fs->aaline_fs == NULL)
goto fail;
if (aaline->fs->aaline_fs != NULL)
aaline->fs->generic_attrib = transform.maxGeneric + 1;
aaline->fs->generic_attrib = transform.maxGeneric + 1;
FREE((void *)aaline_fs.tokens);
return TRUE;
fail:
FREE((void *)aaline_fs.tokens);
return FALSE;
return aaline->fs->aaline_fs != NULL;
}
static boolean
@ -336,13 +331,12 @@ generate_aaline_fs_nir(struct aaline_stage *aaline)
nir_lower_aaline_fs(aaline_fs.ir.nir, &aaline->fs->generic_attrib);
aaline->fs->aaline_fs = aaline->driver_create_fs_state(pipe, &aaline_fs);
if (aaline->fs->aaline_fs == NULL)
goto fail;
return FALSE;
return TRUE;
fail:
#endif
#else
return FALSE;
#endif
}
/**
@ -606,15 +600,12 @@ draw_aaline_stage(struct draw_context *draw)
aaline->stage.reset_stipple_counter = aaline_reset_stipple_counter;
aaline->stage.destroy = aaline_destroy;
if (!draw_alloc_temp_verts(&aaline->stage, 8))
goto fail;
if (!draw_alloc_temp_verts(&aaline->stage, 8)) {
aaline->stage.destroy(&aaline->stage);
return NULL;
}
return aaline;
fail:
aaline->stage.destroy(&aaline->stage);
return NULL;
}