KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

glsl: change ast_type_qualifier bitset size to work around GCC 5.4 bug 

Change the size of the bitset from 128 bits to 96.  This works around an
apparent GCC 5.4 bug in which bad SSE code is generated, leading to a
crash in ast_type_qualifier::validate_in_qualifier() (ast_type.cpp:654).

This can be repro'd with the Piglit test tests/spec/glsl-1.50/execution/
varying-struct-basic-gs-fs.shader_test

Bugzilla:https://bugs.freedesktop.org/show_bug.cgi?id=105497
Cc: mesa-stable@lists.freedesktop.org
Reviewed-by: Charmaine Lee <charmainel@vmware.com>
Tested-by: Charmaine Lee <charmainel@vmware.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
This commit is contained in:
Brian Paul 2018-05-08 08:24:21 -06:00
parent 20f06bc72b
commit 901db25d5b
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/compiler/glsl/ast.h
View File

@ -474,7 +474,13 @@ enum {
struct ast_type_qualifier {
DECLARE_RALLOC_CXX_OPERATORS(ast_type_qualifier);
DECLARE_BITSET_T(bitset_t, 128);
/* Note: this bitset needs to have at least as many bits as the 'q'
* struct has flags, below. Previously, the size was 128 instead of 96.
* But an apparent bug in GCC 5.4.0 causes bad SSE code generation
* elsewhere, leading to a crash. 96 bits works around the issue.
* See https://bugs.freedesktop.org/show_bug.cgi?id=105497
*/
DECLARE_BITSET_T(bitset_t, 96);
union flags {
struct {