KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

v3dv: don't support 1D depth/stencil for transfer sources or sampling 

The hardware can't do sampling from raster depth/stencil textures and
1D images are always raster, even if the user requested optimal tiling.

Using an image as the source of a blit is a transfer source operation,
so we can't expose that either, as blitting involves sampling.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6766>
This commit is contained in:
Iago Toral Quiroga 2020-04-28 09:58:20 +02:00 committed by Marge Bot
parent 94de6a25fb
commit 8b791a5133
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/broadcom/vulkan/v3dv_formats.c
View File

@ -404,6 +404,8 @@ image_format_features(VkFormat vk_format,
/* Raster format is only supported for 1D textures, so let's just
* always require optimal tiling for anything that requires sampling.
* Note: even if the user requests optimal for a 1D image, we will still
* use raster format since that is what the HW requires.
*/
if (v3dv_format->tex_type != TEXTURE_DATA_FORMAT_NO &&
tiling == VK_IMAGE_TILING_OPTIMAL) {
@ -561,6 +563,16 @@ get_image_format_properties(
if (!(format_feature_flags & VK_FORMAT_FEATURE_TRANSFER_SRC_BIT)) {
goto unsupported;
}
/* Sampling of raster depth/stencil images is not supported. Since 1D
* images are always raster, even if the user requested optimal tiling,
* we can't have them be used as transfer sources, since that includes
* using them for blit sources, which might require sampling.
*/
if (info->type == VK_IMAGE_TYPE_1D &&
vk_format_is_depth_or_stencil(info->format)) {
goto unsupported;
}
}
if (info->usage & VK_IMAGE_USAGE_TRANSFER_DST_BIT) {
@ -573,6 +585,15 @@ get_image_format_properties(
if (!(format_feature_flags & VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT)) {
goto unsupported;
}
/* Sampling of raster depth/stencil images is not supported. Since 1D
* images are always raster, even if the user requested optimal tiling,
* we can't allow sampling if the format is depth/stencil.
*/
if (info->type == VK_IMAGE_TYPE_1D &&
vk_format_is_depth_or_stencil(info->format)) {
goto unsupported;
}
}
if (info->usage & VK_IMAGE_USAGE_STORAGE_BIT) {