KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mesa: check cube completeness for cube fbo attachments 

When checking framebuffer completeness, we must verify that each cube
attachment is cube complete, e.g. format and size needs to match.

This fixes upcoming CTS framebuffer completeness tests for cubemaps.

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9748>
This commit is contained in:
Tapani Pälli 2021-03-22 08:32:01 +02:00 committed by Marge Bot
parent 3d94144d38
commit 87de6c3c7d
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/mesa/main/fbobject.c
View File

@ -1333,9 +1333,15 @@ _mesa_test_framebuffer_completeness(struct gl_context *ctx,
/* Check that layered rendering is consistent. */
if (att->Layered) {
if (att_tex_target == GL_TEXTURE_CUBE_MAP)
if (att_tex_target == GL_TEXTURE_CUBE_MAP) {
/* Each layer's format and size must match to the base layer. */
if (!_mesa_cube_complete(att->Texture)) {
fb->_Status = GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT;
fbo_incomplete(ctx, "attachment not cube complete", i);
return;
}
att_layer_count = 6;
else if (att_tex_target == GL_TEXTURE_1D_ARRAY)
} else if (att_tex_target == GL_TEXTURE_1D_ARRAY)
att_layer_count = att->Renderbuffer->Height;
else
att_layer_count = att->Renderbuffer->Depth;