From 863bdd1f8dcb4b36b85f1ab80a3d44eea93a1663 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Wed, 14 Aug 2019 09:11:17 -0700 Subject: [PATCH] pan/midgard: Break, not return, in disassembler We'll want to dump some stats after the shader, and I refuse to use one teensy little goto. Signed-off-by: Alyssa Rosenzweig --- src/panfrost/midgard/disassemble.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/panfrost/midgard/disassemble.c b/src/panfrost/midgard/disassemble.c index 6f4ea486915..8f2020c4c4c 100644 --- a/src/panfrost/midgard/disassemble.c +++ b/src/panfrost/midgard/disassemble.c @@ -1338,9 +1338,6 @@ disassemble_midgard(uint8_t *code, size_t size) case midgard_word_type_alu: print_alu_word(&words[i], num_quad_words, tabs); - if (prefetch_flag) - return; - /* Reset word static analysis state */ is_embedded_constant_half = false; is_embedded_constant_int = false; @@ -1355,6 +1352,9 @@ disassemble_midgard(uint8_t *code, size_t size) break; } + if (prefetch_flag && midgard_word_types[tag] == midgard_word_type_alu) + break; + printf("\n"); unsigned next = (words[i] & 0xF0) >> 4; @@ -1367,7 +1367,7 @@ disassemble_midgard(uint8_t *code, size_t size) prefetch_flag = true; if (midgard_word_types[words[i] & 0xF] != midgard_word_type_alu) - return; + break; } }