zink: add note about buffer<->image copy functions not handling multisample
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6266>
This commit is contained in:
parent
d84a75466c
commit
8239fe5d74
|
@ -408,6 +408,14 @@ zink_transfer_copy_bufimage(struct zink_context *ctx,
|
||||||
int aspect = 1 << u_bit_scan(&aspects);
|
int aspect = 1 << u_bit_scan(&aspects);
|
||||||
copyRegion.imageSubresource.aspectMask = aspect;
|
copyRegion.imageSubresource.aspectMask = aspect;
|
||||||
|
|
||||||
|
/* this may or may not work with multisampled depth/stencil buffers depending on the driver implementation:
|
||||||
|
*
|
||||||
|
* srcImage must have a sample count equal to VK_SAMPLE_COUNT_1_BIT
|
||||||
|
* - vkCmdCopyImageToBuffer spec
|
||||||
|
*
|
||||||
|
* dstImage must have a sample count equal to VK_SAMPLE_COUNT_1_BIT
|
||||||
|
* - vkCmdCopyBufferToImage spec
|
||||||
|
*/
|
||||||
if (buf2img)
|
if (buf2img)
|
||||||
vkCmdCopyBufferToImage(batch->cmdbuf, staging_res->buffer, res->image, res->layout, 1, ©Region);
|
vkCmdCopyBufferToImage(batch->cmdbuf, staging_res->buffer, res->image, res->layout, 1, ©Region);
|
||||||
else
|
else
|
||||||
|
|
Loading…
Reference in New Issue