KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ac/nir: skip gl_ViewportIndex and gl_Layer write in ES 

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Signed-off-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16788>
This commit is contained in:
Qiang Yu 2022-05-30 14:52:57 +08:00
parent 06d493dde2
commit 7ddd15f6c7
1 changed files with 32 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/amd/common/ac_nir_lower_esgs_io_to_mem.c
View File

@ -124,6 +124,38 @@ lower_es_output_store(nir_builder *b,
if (intrin->intrinsic != nir_intrinsic_store_output)
return false;
/* The ARB_shader_viewport_layer_array spec contains the
* following issue:
*
* 2) What happens if gl_ViewportIndex or gl_Layer is
* written in the vertex shader and a geometry shader is
* present?
*
* RESOLVED: The value written by the last vertex processing
* stage is used. If the last vertex processing stage
* (vertex, tessellation evaluation or geometry) does not
* statically assign to gl_ViewportIndex or gl_Layer, index
* or layer zero is assumed.
*
* Vulkan spec 15.7 Built-In Variables:
*
* The last active pre-rasterization shader stage (in pipeline order)
* controls the Layer that is used. Outputs in previous shader stages
* are not used, even if the last stage fails to write the Layer.
*
* The last active pre-rasterization shader stage (in pipeline order)
* controls the ViewportIndex that is used. Outputs in previous shader
* stages are not used, even if the last stage fails to write the
* ViewportIndex.
*
* So writes to those outputs in ES are simply ignored.
*/
unsigned semantic = nir_intrinsic_io_semantics(intrin).location;
if (semantic == VARYING_SLOT_LAYER || semantic == VARYING_SLOT_VIEWPORT) {
nir_instr_remove(instr);
return true;
}
lower_esgs_io_state *st = (lower_esgs_io_state *) state;
unsigned write_mask = nir_intrinsic_write_mask(intrin);