KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

turnip: check the right alignment requirement on shader iova 

I had some trouble because I assumed this was right, tested that the
alignment requirement is actually 16.

Signed-off-by: Jonathan Marek <jonathan@marek.ca>
Reviewed-by: Eric Anholt <eric@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/3979>
This commit is contained in:
Jonathan Marek 2020-02-11 21:11:07 -05:00 committed by Marge Bot
parent 0f0662a551
commit 7d27a9ffb3
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/freedreno/vulkan/tu_pipeline.c
View File

@ -972,7 +972,11 @@ tu6_emit_shader_object(struct tu_cs *cs,
assert(variant->type == stage);
const uint64_t binary_iova = binary_bo->iova + binary_offset;
assert((binary_iova & 0x3) == 0);
assert((binary_iova & 0xf) == 0);
/* note: it looks like HW might try to read a few instructions beyond the instrlen size
* of the shader. this could be a potential source of problems at some point
* possibly this doesn't happen if shader iova is aligned enough (to 4k for example)
*/
tu_cs_emit_pkt4(cs, reg, 2);
tu_cs_emit_qw(cs, binary_iova);