From 7659c6197f08587f57f101a88a7e477337ce363c Mon Sep 17 00:00:00 2001 From: Eric Engestrom Date: Mon, 26 Aug 2019 15:33:31 +0100 Subject: [PATCH] nir: fix memleak in error path Fixes: 2cf59861a8128a91bfdd ("nir: Add partial redundancy elimination for compares") Signed-off-by: Eric Engestrom Reviewed-by: Timothy Arceri Reviewed-by: Ian Romanick --- src/compiler/nir/nir_opt_comparison_pre.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_opt_comparison_pre.c b/src/compiler/nir/nir_opt_comparison_pre.c index 33295e5eea6..a74dfa8939a 100644 --- a/src/compiler/nir/nir_opt_comparison_pre.c +++ b/src/compiler/nir/nir_opt_comparison_pre.c @@ -107,8 +107,10 @@ push_block(struct block_queue *bq) if (!u_vector_init(&bi->instructions, sizeof(nir_alu_instr *), - 8 * sizeof(nir_alu_instr *))) + 8 * sizeof(nir_alu_instr *))) { + free(bi); return NULL; + } exec_list_push_tail(&bq->blocks, &bi->node);