KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

i965: Drop BRW_NEW_PUSH_CONSTANT_ALLOCATION from CS packets. 

I don't think CS push constant uploading uses the section of L3
controlled by 3DSTATE_PUSH_CONSTANT_ALLOC_XS.  So I don't think
it needs to be re-emitted when that space is reallocated.

The programming note in gen7_allocate_push_constants doesn't
indicate this is necessary, at least.

Reviewed-by: Chris Forbes <chrisforbes@google.com>
This commit is contained in:
Kenneth Graunke 2016-11-29 01:30:18 -08:00
parent 82e77d4e44
commit 731b577cc6
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/mesa/drivers/dri/i965/gen7_cs_state.c
View File

@ -133,8 +133,7 @@ const struct brw_tracked_state gen7_cs_push_constants = {
.brw = BRW_NEW_BATCH |
BRW_NEW_BLORP |
BRW_NEW_COMPUTE_PROGRAM |
BRW_NEW_CS_PROG_DATA |
BRW_NEW_PUSH_CONSTANT_ALLOCATION,
BRW_NEW_CS_PROG_DATA,
},
.emit = gen7_upload_cs_push_constants,
};

1
src/mesa/drivers/dri/i965/genX_state_upload.c
View File

@ -3735,7 +3735,6 @@ static const struct brw_tracked_state genX(cs_state) = {
.brw = BRW_NEW_BATCH |
BRW_NEW_BLORP |
BRW_NEW_CS_PROG_DATA |
BRW_NEW_PUSH_CONSTANT_ALLOCATION |
BRW_NEW_SAMPLER_STATE_TABLE |
BRW_NEW_SURFACES,
},