From 6e819585da5e3f25daca9af4806b90678b47c7b5 Mon Sep 17 00:00:00 2001 From: Emma Anholt Date: Tue, 19 Jul 2022 16:33:02 -0700 Subject: [PATCH] ci/turnip: Add a bit of spilling-vs-ballot testing on a618. The shared reg usage involved in the subgroup-related macros can cause trouble for the spiller, and spilling may be implicated in CTS failures with old versions of the subgroup tests, so let's make sure we get some coverage. It does seem to catch a couple of failures. Part-of: --- src/freedreno/ci/deqp-freedreno-a618-vk.toml | 2 +- src/freedreno/ci/freedreno-a618-fails.txt | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/freedreno/ci/deqp-freedreno-a618-vk.toml b/src/freedreno/ci/deqp-freedreno-a618-vk.toml index b607a23a1fa..75dccf7fced 100644 --- a/src/freedreno/ci/deqp-freedreno-a618-vk.toml +++ b/src/freedreno/ci/deqp-freedreno-a618-vk.toml @@ -21,7 +21,7 @@ TU_DEBUG = "gmem,forcebin" deqp = "/deqp/external/vulkancts/modules/vulkan/deqp-vk" caselists = ["/deqp/mustpass/vk-master.txt"] skips = ["install/freedreno-a618-premerge-skips.txt"] -include = ["dEQP-VK.graphicsfuzz.*"] +include = ["dEQP-VK.graphicsfuzz.*", "dEQP-VK.subgroups.ballot*"] prefix = "spill-" [deqp.env] IR3_SHADER_DEBUG = "spillall" diff --git a/src/freedreno/ci/freedreno-a618-fails.txt b/src/freedreno/ci/freedreno-a618-fails.txt index fa40ed4fc1d..615df96bd0d 100644 --- a/src/freedreno/ci/freedreno-a618-fails.txt +++ b/src/freedreno/ci/freedreno-a618-fails.txt @@ -26,3 +26,6 @@ dEQP-VK.pipeline.monolithic.color_write_enable_maxa.cwe_after_bind.attachments5_ dEQP-VK.pipeline.monolithic.color_write_enable_maxa.cwe_after_bind.attachments5_more3,Crash dEQP-VK.pipeline.monolithic.color_write_enable_maxa.cwe_after_bind.attachments6_more0,Crash dEQP-VK.pipeline.monolithic.color_write_enable_maxa.cwe_after_bind.attachments6_more1,Crash + +spill-dEQP-VK.subgroups.ballot_broadcast.compute.subgroupbroadcast_bool,Fail +spill-dEQP-VK.subgroups.ballot_broadcast.compute.subgroupbroadcast_bool_requiredsubgroupsize128,Fail