KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

microsoft/compiler: Delete misleading TODO comments about semantic table 

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Bill Kristiansen <billkris@microsoft.com>

We've been writing a valid semantic table for a while now.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14399>
This commit is contained in:
Jesse Natalie 2022-01-02 11:56:09 -08:00 committed by Marge Bot
parent f511354a64
commit 6c58e1f448
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/microsoft/compiler/dxil_container.c
View File

@ -204,7 +204,6 @@ dxil_container_add_state_validation(struct dxil_container *c,
uint32_t string_table_size = (m->sem_string_table->length + 3) & ~3u;
size += sizeof(uint32_t) + string_table_size;
// Semantic index table size, currently always 0
size += sizeof(uint32_t) + m->sem_index_table.size * sizeof(uint32_t);
if (m->num_sig_inputs || m->num_sig_outputs) {
@ -222,7 +221,6 @@ dxil_container_add_state_validation(struct dxil_container *c,
// TODO: Add viewID records size
// TODO: Add sig input output dependency table size
uint32_t dependency_table_size = 0;
if (state->state.sig_input_vectors > 0) {
for (unsigned i = 0; i < 4; ++i) {
@ -259,7 +257,6 @@ dxil_container_add_state_validation(struct dxil_container *c,
!blob_write_bytes(&c->parts, &fill, string_table_size - m->sem_string_table->length))
return false;
// TODO: write the correct semantic index table. Currently it is empty
if (!blob_write_bytes(&c->parts, &m->sem_index_table.size, sizeof(uint32_t)))
return false;