KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mesa: If validation fails in a debug context just emit a debug message 

There are quite a few pipelines that desktop applications (including a
bunch of piglit test) can expect to have run but don't meet the GLES
requirements.  Instead of failing validation, just emit a debug message.

Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96358
Cc: "12.0" <mesa-stable@lists.freedesktop.org>
Cc: Gregory Hainaut <gregory.hainaut@gmail.com>
Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>
Reviewed-by: Timothy Arceri <timothy.arceri@collabora.com>
This commit is contained in:
Ian Romanick 2016-06-13 09:59:10 -07:00
parent 9c87282041
commit 6bec55a780
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/mesa/main/pipelineobj.c
View File

@ -929,8 +929,21 @@ _mesa_validate_program_pipeline(struct gl_context* ctx,
* application has created a debug context.
*/
if ((_mesa_is_gles(ctx) || (ctx->Const.ContextFlags & GL_CONTEXT_FLAG_DEBUG_BIT)) &&
!_mesa_validate_pipeline_io(pipe))
return GL_FALSE;
!_mesa_validate_pipeline_io(pipe)) {
if (_mesa_is_gles(ctx))
return GL_FALSE;
static GLuint msg_id = 0;
_mesa_gl_debug(ctx, &msg_id,
MESA_DEBUG_SOURCE_API,
MESA_DEBUG_TYPE_PORTABILITY,
MESA_DEBUG_SEVERITY_MEDIUM,
"glValidateProgramPipeline: pipeline %u does not meet "
"strict OpenGL ES 3.1 requirements and may not be "
"portable across desktop hardware\n",
pipe->Name);
}
pipe->Validated = GL_TRUE;
return GL_TRUE;