KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

zink/codegen: do not automatically consider extensions promoted 

...until an entry is added to VERSIONS in zink_device_info.py.

Now that we stop obtaining feature structs of promoted extensions when the VK
impl is new enough, it's possible for things to break when someone updates
vk.xml, and extensions get promoted but the codegen is not updated to include
e.g. info->feats13 and info->props13 (or newer) in zink_device_info

Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16265>
This commit is contained in:
Hoe Hao Cheng 2022-05-01 18:03:52 +08:00 committed by Marge Bot
parent 07565e8852
commit 687fd67557
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/gallium/drivers/zink/zink_device_info.py
View File

@ -682,8 +682,13 @@ if __name__ == "__main__":
print("The extension {} does not provide a properties struct.".format(ext.name))
ext.properties_promoted = entry.properties_promoted
if entry.promoted_in:
if entry.promoted_in and entry.promoted_in <= versions[-1].struct_version:
ext.core_since = Version((*entry.promoted_in, 0))
else:
# even if the ext is promoted in a newer VK version, consider it
# unpromoted until there's an entry for that VK version in VERSIONS
ext.features_promoted = False
ext.properties_promoted = False
if error_count > 0:
print("zink_device_info.py: Found {} error(s) in total. Quitting.".format(error_count))