KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

panfrost: Use packed TLS on Valhall 

Packed TLS has cache-locality benefits on Valhall, compared to Bifrost's flat
TLS. Valhall does support flat TLS, but requires extra arithmetic in the shader
for correct results. At least until we get to generic pointers (and maybe even
then), we can use packed TLS. So just use packed TLS always for proper spilling.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16314>
This commit is contained in:
Alyssa Rosenzweig 2022-05-03 16:34:52 -04:00 committed by Marge Bot
parent 98bdc4a5ff
commit 6761dbf891
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/panfrost/lib/pan_cs.c
View File

@ -484,7 +484,19 @@ GENX(pan_emit_tls)(const struct pan_tls_info *info,
panfrost_get_stack_shift(info->tls.size);
cfg.tls_size = shift;
#if PAN_ARCH >= 9
/* For now, always use packed TLS addressing. This is
* better for the cache and requires no fix up code in
* the shader. We may need to revisit this someday for
* OpenCL generic pointer support.
*/
cfg.tls_address_mode = MALI_ADDRESS_MODE_PACKED;
assert((info->tls.ptr & 4095) == 0);
cfg.tls_base_pointer = info->tls.ptr >> 8;
#else
cfg.tls_base_pointer = info->tls.ptr;
#endif
}
if (info->wls.size) {