KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

i965/vec4: Prevent copy propagation from violating pre-gen8 restrictions 

In gen < 8 instructions that write more than one register need to read
more than one register too. Make sure we don't break that restriction
by copy propagating from a uniform.

Reviewed-by: Matt Turner <mattst88@gmail.com>
This commit is contained in:
Iago Toral Quiroga 2016-06-23 08:34:53 +02:00 committed by Samuel Iglesias Gonsálvez
parent 70cc6b0a02
commit 6637312847
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp
View File

@ -324,6 +324,13 @@ try_copy_propagate(const struct gen_device_info *devinfo,
value.file != ATTR)
return false;
/* In gen < 8 instructions that write 2 registers also need to read 2
* registers. Make sure we don't break that restriction by copy
* propagating from a uniform.
*/
if (devinfo->gen < 8 && inst->size_written > REG_SIZE && is_uniform(value))
return false;
/* If the type of the copy value is different from the type of the
* instruction then the swizzles and writemasks involved don't have the same
* meaning and simply replacing the source would produce different semantics.