KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

st/mesa: Fix EGLImageTargetTexture2D for GL_TEXTURE_2D 

Before this change, internalFormat was defaulted to GL_RGBA (
unsized internal format). Therefore, subsequent glTexSubImage2D
call with type != GL_UNSIGNED_BYTE, GL_UNSIGNED_SHORT_4_4_4_4 or
GL_UNSIGNED_SHORT_5_5_5_1 would give GL_INVALID_OPERATION.

This fixes

android.graphics.cts.BitmapColorSpaceTest#test16bitHardware
android.graphics.cts.ImageDecoderTest#testDecodeBitmap*
android.graphics.cts.BitmapTest#testNdkFormatsHardware

in CtsGraphicsTestCases

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6382>
This commit is contained in:
Woody Chow 2020-08-19 14:19:12 +09:00 committed by Marge Bot
parent 855afe0144
commit 5e4d69ec78
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mesa/state_tracker/st_cb_eglimage.c
View File

@ -327,7 +327,9 @@ st_egl_image_target_texture_2d(struct gl_context *ctx, GLenum target,
&native_supported))
return;
st_bind_egl_image(ctx, texObj, texImage, &stimg, false, native_supported);
st_bind_egl_image(ctx, texObj, texImage, &stimg,
target != GL_TEXTURE_EXTERNAL_OES,
native_supported);
pipe_resource_reference(&stimg.texture, NULL);
}