egl: return correct error code for a case req ver < 3 with forward-compatible
The EGL_KHR_create_context spec says: "If an OpenGL context is requested and the values for attributes EGL_CONTEXT_MAJOR_VERSION_KHR and EGL_CONTEXT_MINOR_VERSION_KHR, when considered together with the value for attribute EGL_CONTEXT_OPENGL_FORWARD_COMPATIBLE_BIT_KHR, specify an OpenGL version and feature set that are not defined, than an EGL_BAD_MATCH error is generated." This case is already correctly handled a bit below in the same source file. The correct handling was added by commit:63beb3df
Reported-by: Ian Romanick <idr@freedesktop.org> Here: https://bugzilla.freedesktop.org/show_bug.cgi?id=92552#c9 Fixes:11cabc45b7
"egl: rework handling EGL_CONTEXT_FLAGS" Reviewed-by: Ian Romanick <ian.d.romanick@intel.com> Signed-off-by: Andrii Simiklit <andrii.simiklit@globallogic.com>
This commit is contained in:
parent
90f3bf7437
commit
5c581b3dd6
|
@ -178,9 +178,12 @@ _eglParseContextAttribList(_EGLContext *ctx, _EGLDisplay *disp,
|
|||
* is supported for OpenGL contexts, and requesting a
|
||||
* forward-compatible context for OpenGL versions less than 3.0
|
||||
* will generate an error."
|
||||
*
|
||||
* Note: since the forward-compatible flag can be set more than one way,
|
||||
* the OpenGL version check is performed once, below.
|
||||
*/
|
||||
if ((val & EGL_CONTEXT_OPENGL_FORWARD_COMPATIBLE_BIT_KHR) &&
|
||||
(api != EGL_OPENGL_API || ctx->ClientMajorVersion < 3)) {
|
||||
api != EGL_OPENGL_API) {
|
||||
err = EGL_BAD_ATTRIBUTE;
|
||||
break;
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue