nir: Drop our attempt at typed-based image mode validation
This is broken for bindless images declared as local variables. It turns out nir_variable::data::bindless is only used for uniforms and we already assume anything in nir_var_function_temp or similar is bindless. We could try to make a tricky assert but now that we have everything else passing but now that we've got everyone converted the extra validation probably isn't necessary. Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13384>
This commit is contained in:
parent
d05f7b4a2c
commit
58f605e4d4
|
@ -1518,9 +1518,6 @@ validate_var_decl(nir_variable *var, nir_variable_mode valid_modes,
|
|||
if (var->constant_initializer)
|
||||
validate_constant(var->constant_initializer, var->type, state);
|
||||
|
||||
if (glsl_type_contains_image(var->type) && !var->data.bindless)
|
||||
validate_assert(state, var->data.mode == nir_var_mem_image);
|
||||
|
||||
if (var->data.mode == nir_var_mem_image) {
|
||||
validate_assert(state, !var->data.bindless);
|
||||
validate_assert(state, glsl_type_is_image(glsl_without_array(var->type)));
|
||||
|
|
Loading…
Reference in New Issue