KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

radv/aco: enable FP16 features/extensions on GFX9+ 

This enables shaderFloat16, VK_AMD_gpu_shader_half_float and
VK_AMD_gpu_shader_int16.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5347>
This commit is contained in:
Samuel Pitoiset 2020-06-05 09:27:01 +02:00
parent abfe28a6bb
commit 51fb3b09dc
4 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/relnotes/new_features.txt
View File

@ -1,6 +1,8 @@
GL_ARB_compute_variable_group_size on Iris.
GL_EXT_shader_group_vote on GLES3.
VK_AMD_texture_gather_bias_lod on RADV.
VK_AMD_gpu_shader_half_float on RADV/ACO.
VK_AMD_gpu_shader_int16 on RADV/ACO.
VK_EXT_private_data on ANV and RADV.
VK_EXT_custom_border_color on ANV and RADV.
VK_EXT_pipeline_creation_cache_control on ANV and RADV.

2
src/amd/vulkan/radv_device.c
View File

@ -988,7 +988,7 @@ radv_get_physical_device_features_1_2(struct radv_physical_device *pdevice,
f->storagePushConstant8 = true;
f->shaderBufferInt64Atomics = LLVM_VERSION_MAJOR >= 9 || pdevice->use_aco;
f->shaderSharedInt64Atomics = LLVM_VERSION_MAJOR >= 9 || pdevice->use_aco;
f->shaderFloat16 = pdevice->rad_info.has_packed_math_16bit && !pdevice->use_aco;
f->shaderFloat16 = pdevice->rad_info.has_packed_math_16bit;
f->shaderInt8 = true;
f->descriptorIndexing = true;

4
src/amd/vulkan/radv_extensions.py
View File

@ -165,8 +165,8 @@ EXTENSIONS = [
Extension('VK_AMD_device_coherent_memory', 1, True),
Extension('VK_AMD_draw_indirect_count', 1, True),
Extension('VK_AMD_gcn_shader', 1, True),
Extension('VK_AMD_gpu_shader_half_float', 1, '!device->use_aco && device->rad_info.has_packed_math_16bit'),
Extension('VK_AMD_gpu_shader_int16', 1, '!device->use_aco && device->rad_info.has_packed_math_16bit'),
Extension('VK_AMD_gpu_shader_half_float', 1, 'device->rad_info.has_packed_math_16bit'),
Extension('VK_AMD_gpu_shader_int16', 1, 'device->rad_info.has_packed_math_16bit'),
Extension('VK_AMD_memory_overallocation_behavior', 1, True),
# Disable mixed attachment samples on GFX6-GFX7 until the CTS failures have been resolved.
Extension('VK_AMD_mixed_attachment_samples', 1, 'device->rad_info.chip_class >= GFX8'),

2
src/amd/vulkan/radv_shader.c
View File

@ -369,7 +369,7 @@ radv_shader_compile_to_nir(struct radv_device *device,
.device_group = true,
.draw_parameters = true,
.float_controls = true,
.float16 = device->physical_device->rad_info.has_packed_math_16bit && !device->physical_device->use_aco,
.float16 = device->physical_device->rad_info.has_packed_math_16bit,
.float64 = true,
.geometry_streams = true,
.image_ms_array = true,