KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

broadcom/compiler: don't check for GFXH-1633 on V3D 4.2.x 

This has been fixed since V3D 4.2.14 (Rpi4), which is the hardware
we are targetting. Our version resolution doesn't allow us to check
for 4.2 versions lower than .14, but that is okay because the
simulator would still validate this in any case.

Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8980>
This commit is contained in:
Iago Toral Quiroga 2021-02-11 11:52:13 +01:00 committed by Marge Bot
parent 457ed5aa01
commit 4b929ae9f0
1 changed files with 19 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/broadcom/compiler/qpu_validate.c
View File

@ -124,17 +124,25 @@ qpu_validate_inst(struct v3d_qpu_validate_state *state, struct qinst *qinst)
fail_instr(state, "LDUNIF after a LDVARY");
}
/* GFXH-1633 */
bool last_reads_ldunif = (state->last && (state->last->sig.ldunif ||
state->last->sig.ldunifrf));
bool last_reads_ldunifa = (state->last && (state->last->sig.ldunifa ||
state->last->sig.ldunifarf));
bool reads_ldunif = inst->sig.ldunif || inst->sig.ldunifrf;
bool reads_ldunifa = inst->sig.ldunifa || inst->sig.ldunifarf;
if ((last_reads_ldunif && reads_ldunifa) ||
(last_reads_ldunifa && reads_ldunif)) {
fail_instr(state,
"LDUNIF and LDUNIFA can't be next to each other");
/* GFXH-1633 (fixed since V3D 4.2.14, which is Rpi4)
*
* FIXME: This would not check correctly for V3D 4.2 versions lower
* than V3D 4.2.14, but that is not a real issue because the simulator
* will still catch this, and we are not really targetting any such
* versions anyway.
*/
if (state->c->devinfo->ver < 42) {
bool last_reads_ldunif = (state->last && (state->last->sig.ldunif ||
state->last->sig.ldunifrf));
bool last_reads_ldunifa = (state->last && (state->last->sig.ldunifa ||
state->last->sig.ldunifarf));
bool reads_ldunif = inst->sig.ldunif || inst->sig.ldunifrf;
bool reads_ldunifa = inst->sig.ldunifa || inst->sig.ldunifarf;
if ((last_reads_ldunif && reads_ldunifa) ||
(last_reads_ldunifa && reads_ldunif)) {
fail_instr(state,
"LDUNIF and LDUNIFA can't be next to each other");
}
}
int tmu_writes = 0;