From 47b70ca5843269c83e949b1cbc1d2c111e2234a1 Mon Sep 17 00:00:00 2001
From: Alyssa Rosenzweig <alyssa@collabora.com>
Date: Wed, 2 Mar 2022 10:36:43 -0500
Subject: [PATCH] pan/va: Add modifiers required for gathers

Mostly isomorphic to Bifrost-style gathers.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15216>
---
 src/panfrost/bifrost/valhall/ISA.xml    | 7 +++++++
 src/panfrost/bifrost/valhall/valhall.py | 2 ++
 2 files changed, 9 insertions(+)

diff --git a/src/panfrost/bifrost/valhall/ISA.xml b/src/panfrost/bifrost/valhall/ISA.xml
index 172eb86aeca..e20adb2de34 100644
--- a/src/panfrost/bifrost/valhall/ISA.xml
+++ b/src/panfrost/bifrost/valhall/ISA.xml
@@ -548,6 +548,13 @@
     <value default="true">rgba</value>
   </enum>
 
+  <enum name="Fetch component">
+    <value desc="Red">gather4_r</value>
+    <value desc="Green">gather4_g</value>
+    <value desc="Blue">gather4_b</value>
+    <value desc="Alpha">gather4_a</value>
+  </enum>
+
   <enum name="Register type">
     <desc>Unsized type, part of a register format.</desc>
     <reserved/>
diff --git a/src/panfrost/bifrost/valhall/valhall.py b/src/panfrost/bifrost/valhall/valhall.py
index 020b2c00f35..b9abccd450a 100644
--- a/src/panfrost/bifrost/valhall/valhall.py
+++ b/src/panfrost/bifrost/valhall/valhall.py
@@ -349,6 +349,8 @@ MODIFIERS = {
     "array_enable": Flag("array_enable", 10),
     "texel_offset": Flag("texel_offset", 11),
     "shadow": Flag("shadow", 12),
+    "integer_coordinates": Flag("integer_coordinates", 13),
+    "fetch_component": Modifier("fetch_component", 14, 2),
     "lod_mode": Modifier("lod_mode", 13, 3),
     "write_mask": Modifier("write_mask", 22, 4),
     "register_type": Modifier("register_type", 26, 2),