KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

aco: use 32-bit inline constants for 16-bit integer instructions 

See https://reviews.llvm.org/D81841

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5245>
This commit is contained in:
Rhys Perry 2020-06-15 14:30:34 +01:00 committed by Marge Bot
parent dd23345567
commit 4784111abc
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/amd/compiler/aco_opcodes.py
View File

@ -194,12 +194,21 @@ class Opcode(object):
parts = name.replace('_e64', '').rsplit('_', 2)
op_dtype = parts[-1]
def_dtype = parts[-2] if len(parts) > 1 else parts[-1]
dtype_sizes = {'{}{}'.format(prefix, size) : size for prefix in 'biuf' for size in [64, 32, 24, 16]}
self.operand_size = dtype_sizes.get(op_dtype, 0)
self.definition_size = dtype_sizes.get(def_dtype, self.operand_size)
def_dtype_sizes = {'{}{}'.format(prefix, size) : size for prefix in 'biuf' for size in [64, 32, 24, 16]}
op_dtype_sizes = {k:v for k, v in def_dtype_sizes.items()}
# inline constants are 32-bit for 16-bit integer/typeless instructions: https://reviews.llvm.org/D81841
op_dtype_sizes['b16'] = 32
op_dtype_sizes['i16'] = 32
op_dtype_sizes['u16'] = 32
self.operand_size = op_dtype_sizes.get(op_dtype, 0)
self.definition_size = def_dtype_sizes.get(def_dtype, self.operand_size)
# exceptions
if self.operand_size == 24:
if self.operand_size == 16 and op_dtype != 'f16':
self.operand_size = 16
elif self.operand_size == 24:
self.operand_size = 32
elif name in ['s_sext_i32_i8', 's_sext_i32_i16', 'v_msad_u8', 'v_cvt_pk_u16_u32', 'v_cvt_pk_i16_i32']:
self.operand_size = 32
@ -208,9 +217,6 @@ class Opcode(object):
self.operand_size = 0
elif name in ['v_mad_u64_u32', 'v_mad_i64_i32']:
self.operand_size = 0
elif name.replace('_e64', '') in ['v_lshrrev_b16', 'v_ashrrev_i16', 'v_lshlrev_b16']:
# v_lshlrev_b16 tested on GFX10 with 1/2 PI inline constant
self.operand_size = 32
elif '_pk_' in name or name in ['v_lerp_u8', 'v_sad_u8', 'v_sad_u16',
'v_cvt_f32_ubyte0', 'v_cvt_f32_ubyte1',
'v_cvt_f32_ubyte2', 'v_cvt_f32_ubyte3']: