KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pan/midgard: Extend SSA concurrency checks to other args 

No glmark changes, but this seems like a good idea.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
This commit is contained in:
Alyssa Rosenzweig 2019-08-05 11:22:49 -07:00
parent 2869758355
commit 3db4949197
1 changed files with 12 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/panfrost/midgard/midgard_schedule.c
View File

@ -72,23 +72,22 @@ can_run_concurrent_ssa(midgard_instruction *first, midgard_instruction *second)
int source_mask = first->mask;
/* As long as the second doesn't read from the first, we're okay */
if (second->ssa_args.src[0] == source) {
if (first->type == TAG_ALU_4) {
/* Figure out which components we just read from */
for (unsigned i = 0; i < ARRAY_SIZE(second->ssa_args.src); ++i) {
if (second->ssa_args.src[i] != source)
continue;
int q = second->alu.src1;
midgard_vector_alu_src *m = (midgard_vector_alu_src *) &q;
/* Check if there are components in common, and fail if so */
if (swizzle_to_access_mask(m->swizzle) & source_mask)
return false;
} else
if (first->type != TAG_ALU_4)
return false;
}
/* Figure out which components we just read from */
if (second->ssa_args.src[1] == source)
return false;
int q = (i == 0) ? second->alu.src1 : second->alu.src2;
midgard_vector_alu_src *m = (midgard_vector_alu_src *) &q;
/* Check if there are components in common, and fail if so */
if (swizzle_to_access_mask(m->swizzle) & source_mask)
return false;
}
/* Otherwise, it's safe in that regard. Another data hazard is both
* writing to the same place, of course */