ci/piglit: Skip glx_arb_sync_control@timing.* on all systems.

The test involves timestamping to figure out how long a swap actually
takes, but if anything ends up rescheduling the process you can end up
spuriously failing.  I could easily reproduce flakiness by just running a
loop accessing the filesystem in parallel with a loop running the test.
So, it's certainly not usable on a CI system with other piglit tests
running in parallel, and we don't want to run it if it's going to just
produce flake noise.

Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11333>
This commit is contained in:
Emma Anholt 2021-06-11 14:40:06 -07:00
parent e594b18d6a
commit 323abf2fb2
10 changed files with 4 additions and 73 deletions

View File

@ -1,2 +1,6 @@
# WGL is Windows-only
wgl@.*
# These are sensitive to CPU timing, and would need to be run in isolation
# on the system rather than in parallel with other tests.
glx@glx_arb_sync_control@timing.*

View File

@ -1,16 +1,4 @@
glx@glx_arb_sync_control@swapbuffersmsc-divisor-zero
glx@glx_arb_sync_control@timing
glx@glx_arb_sync_control@timing -divisor 1
glx@glx_arb_sync_control@timing -divisor 2
glx@glx_arb_sync_control@timing -fullscreen -divisor 1
glx@glx_arb_sync_control@timing -fullscreen -divisor 2
glx@glx_arb_sync_control@timing -fullscreen -msc-delta 1
glx@glx_arb_sync_control@timing -fullscreen -msc-delta 2
glx@glx_arb_sync_control@timing -msc-delta 1
glx@glx_arb_sync_control@timing -msc-delta 2
glx@glx_arb_sync_control@timing -waitformsc -divisor 1
glx@glx_arb_sync_control@timing -waitformsc -divisor 2
glx@glx_arb_sync_control@timing -waitformsc -msc-delta 1
glx@glx_arb_sync_control@waitformsc
spec@!opengl 1.1@depthstencil-default_fb-drawpixels-24_8 samples=4
spec@!opengl 1.1@depthstencil-default_fb-drawpixels-float-and-ushort samples=4

View File

@ -1,14 +1,4 @@
glx@glx-multi-window-single-context
glx@glx_arb_sync_control@timing
glx@glx_arb_sync_control@timing -divisor 1
glx@glx_arb_sync_control@timing -divisor 2
glx@glx_arb_sync_control@timing -fullscreen -divisor 1
glx@glx_arb_sync_control@timing -fullscreen -divisor 2
glx@glx_arb_sync_control@timing -fullscreen -msc-delta 2
glx@glx_arb_sync_control@timing -msc-delta 2
glx@glx_arb_sync_control@timing -waitformsc -divisor 1
glx@glx_arb_sync_control@timing -waitformsc -divisor 2
glx@glx_arb_sync_control@timing -waitformsc -msc-delta 2
shaders@glsl-vs-loop
shaders@glsl-vs-loop-nested
spec@arb_framebuffer_srgb@blit renderbuffer srgb single_sampled enabled clear

View File

@ -9,18 +9,6 @@ glx@glx-visuals-stencil -pixmap,Crash
glx@glx_arb_create_context_es2_profile@invalid opengl es version,Fail
glx@glx_arb_create_context_robustness@invalid reset notification strategy,Fail
glx@glx_arb_sync_control@swapbuffersmsc-divisor-zero,Fail
glx@glx_arb_sync_control@timing -divisor 1,Fail
glx@glx_arb_sync_control@timing -divisor 2,Fail
glx@glx_arb_sync_control@timing -fullscreen -divisor 1,Fail
glx@glx_arb_sync_control@timing -fullscreen -divisor 2,Fail
glx@glx_arb_sync_control@timing -fullscreen -msc-delta 1,Fail
glx@glx_arb_sync_control@timing -fullscreen -msc-delta 2,Fail
glx@glx_arb_sync_control@timing -msc-delta 1,Fail
glx@glx_arb_sync_control@timing -msc-delta 2,Fail
glx@glx_arb_sync_control@timing -waitformsc -divisor 1,Fail
glx@glx_arb_sync_control@timing -waitformsc -divisor 2,Fail
glx@glx_arb_sync_control@timing -waitformsc -msc-delta 1,Fail
glx@glx_arb_sync_control@timing -waitformsc -msc-delta 2,Fail
glx@glx_arb_sync_control@waitformsc,Fail
glx@glx_ext_import_context@free context,Fail
glx@glx_ext_import_context@get context id,Fail

View File

@ -1,9 +1,5 @@
glx@glx_arb_create_context_es2_profile@invalid opengl es version,Fail
glx@glx_arb_create_context_robustness@invalid reset notification strategy,Fail
glx@glx_arb_sync_control@timing -fullscreen -divisor 2,Fail
glx@glx_arb_sync_control@timing -fullscreen -msc-delta 1,Fail
glx@glx_arb_sync_control@timing -waitformsc -divisor 1,Fail
glx@glx_arb_sync_control@timing -waitformsc -msc-delta 2,Fail
glx@glx-copy-sub-buffer samples=2,Fail
glx@glx_ext_import_context@free context,Fail
glx@glx_ext_import_context@get context id,Fail

View File

@ -1,16 +1,4 @@
glx@glx_arb_sync_control@swapbuffersmsc-divisor-zero
glx@glx_arb_sync_control@timing -divisor 1
glx@glx_arb_sync_control@timing -divisor 2
glx@glx_arb_sync_control@timing -msc-delta 1
glx@glx_arb_sync_control@timing -msc-delta 2
glx@glx_arb_sync_control@timing -fullscreen -divisor 1
glx@glx_arb_sync_control@timing -fullscreen -divisor 2
glx@glx_arb_sync_control@timing -fullscreen -msc-delta 1
glx@glx_arb_sync_control@timing -fullscreen -msc-delta 2
glx@glx_arb_sync_control@timing -waitformsc -divisor 1
glx@glx_arb_sync_control@timing -waitformsc -divisor 2
glx@glx_arb_sync_control@timing -waitformsc -msc-delta 1
glx@glx_arb_sync_control@timing -waitformsc -msc-delta 2
glx@glx_arb_sync_control@waitformsc
glx@glx-copy-sub-buffer.*
glx@glx-swap-copy

View File

@ -93,18 +93,6 @@ glx@glx_arb_sync_control@swapbuffersmsc-divisor-zero,Fail
glx@glx_arb_sync_control@swapbuffersmsc-return,Fail
glx@glx_arb_sync_control@swapbuffersmsc-return swap_interval 0,Fail
glx@glx_arb_sync_control@swapbuffersmsc-return swap_interval 1,Fail
glx@glx_arb_sync_control@timing -divisor 1,Fail
glx@glx_arb_sync_control@timing -divisor 2,Fail
glx@glx_arb_sync_control@timing -fullscreen -divisor 1,Fail
glx@glx_arb_sync_control@timing -fullscreen -divisor 2,Fail
glx@glx_arb_sync_control@timing -fullscreen -msc-delta 1,Fail
glx@glx_arb_sync_control@timing -fullscreen -msc-delta 2,Fail
glx@glx_arb_sync_control@timing -msc-delta 1,Fail
glx@glx_arb_sync_control@timing -msc-delta 2,Fail
glx@glx_arb_sync_control@timing -waitformsc -divisor 1,Fail
glx@glx_arb_sync_control@timing -waitformsc -divisor 2,Fail
glx@glx_arb_sync_control@timing -waitformsc -msc-delta 1,Fail
glx@glx_arb_sync_control@timing -waitformsc -msc-delta 2,Fail
glx@glx_arb_sync_control@waitformsc,Fail
glx@glx_ext_import_context@free context,Fail
glx@glx_ext_import_context@get context id,Fail

View File

@ -32,14 +32,6 @@ glx@glx_arb_create_context_robustness@invalid reset notification strategy,Fail
# Version = 3.3
glx@glx_arb_create_context_es2_profile@invalid opengl es version,Fail
# piglit: error: Test timed out.
glx@glx_arb_sync_control@timing -divisor 1,Fail
glx@glx_arb_sync_control@timing -fullscreen -divisor 1,Fail
glx@glx_arb_sync_control@timing -fullscreen -divisor 2,Fail
glx@glx_arb_sync_control@timing -fullscreen -msc-delta 1,Fail
glx@glx_arb_sync_control@timing -msc-delta 2,Fail
glx@glx_arb_sync_control@timing -waitformsc -msc-delta 1,Fail
# Xorg has disabled indirect rendering contexts.
glx@glx_ext_import_context@free context,Fail
glx@glx_ext_import_context@get context id,Fail

View File

@ -1,5 +1,3 @@
glx@glx_arb_sync_control@timing.*
# Some flaky tests found:
# spec@arb_query_buffer_object@qbo@query-GL_ANY_SAMPLES_PASSED-SYNC-GL_INT
# spec@arb_query_buffer_object@qbo@query-GL_GEOMETRY_SHADER_PRIMITIVES_EMITTED-ASYNC-GL_UNSIGNED_INT64_ARB

View File

@ -1 +0,0 @@
glx@glx_arb_sync_control@timing -fullscreen -divisor 2