From 2ff2a5877454a5bcfb53cf3b0c07cda239f13f74 Mon Sep 17 00:00:00 2001 From: Brian Paul Date: Fri, 8 Mar 2019 14:08:13 -0700 Subject: [PATCH] llvmpipe: stop using pipe_sampler_view_release() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This was used to avoid freeing a sampler view which was created by a context that was already deleted. But the state tracker does not allow that. Reviewed-by: Roland Scheidegger Reviewed-by: Neha Bhende Reviewed-by: Mathias Fröhlich Reviewed-By: Jose Fonseca --- src/gallium/drivers/llvmpipe/lp_state_sampler.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_state_sampler.c b/src/gallium/drivers/llvmpipe/lp_state_sampler.c index c9aba1a8594..72823e4c84a 100644 --- a/src/gallium/drivers/llvmpipe/lp_state_sampler.c +++ b/src/gallium/drivers/llvmpipe/lp_state_sampler.c @@ -123,12 +123,6 @@ llvmpipe_set_sampler_views(struct pipe_context *pipe, /* set the new sampler views */ for (i = 0; i < num; i++) { - /* Note: we're using pipe_sampler_view_release() here to work around - * a possible crash when the old view belongs to another context that - * was already destroyed. - */ - pipe_sampler_view_release(pipe, - &llvmpipe->sampler_views[shader][start + i]); /* * Warn if someone tries to set a view created in a different context * (which is why we need the hack above in the first place).