From 2809e2e816069ae267fb429d9c0fafd75db9e58c Mon Sep 17 00:00:00 2001 From: Iago Toral Quiroga Date: Thu, 26 Nov 2020 08:02:36 +0100 Subject: [PATCH] v3dv: fix leak in the buffer to image copy via texel buffer MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes: ba69c36ada5 ("v3dv: add a buffer to image copy path using a texel buffer") Reviewed-by: Alejandro PiƱeiro Part-of: --- src/broadcom/vulkan/v3dv_meta_copy.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/broadcom/vulkan/v3dv_meta_copy.c b/src/broadcom/vulkan/v3dv_meta_copy.c index 70307bf30f6..534ae20ef09 100644 --- a/src/broadcom/vulkan/v3dv_meta_copy.c +++ b/src/broadcom/vulkan/v3dv_meta_copy.c @@ -3223,6 +3223,10 @@ texel_buffer_shader_copy(struct v3dv_cmd_buffer *cmd_buffer, if (result != VK_SUCCESS) goto fail; + v3dv_cmd_buffer_add_private_obj( + cmd_buffer, (uintptr_t)image_view, + (v3dv_cmd_buffer_private_obj_destroy_cb)v3dv_DestroyImageView); + VkFramebufferCreateInfo fb_info = { .sType = VK_STRUCTURE_TYPE_FRAMEBUFFER_CREATE_INFO, .renderPass = pipeline->pass,