KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

v3dv/util: remove several logging functions 

We already have vk_error to report errors, they add little specific
v3dv wrapping over a simple fprintf, and they are not used really
often.

Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7497>
This commit is contained in:
Alejandro Piñeiro 2020-11-08 22:44:40 +01:00 committed by Marge Bot
parent 1675c83a4f
commit 1fa4a37256
2 changed files with 1 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/broadcom/vulkan/v3dv_private.h
View File

@ -1762,8 +1762,6 @@ v3dv_device_entrypoint_is_enabled(int index, uint32_t core_version,
void *v3dv_lookup_entrypoint(const struct v3d_device_info *devinfo,
const char *name);
#define v3dv_printflike(a, b) __attribute__((__format__(__printf__, a, b)))
VkResult __vk_errorf(struct v3dv_instance *instance, VkResult error,
const char *file, int line,
const char *format, ...);
@ -1771,11 +1769,8 @@ VkResult __vk_errorf(struct v3dv_instance *instance, VkResult error,
#define vk_error(instance, error) __vk_errorf(instance, error, __FILE__, __LINE__, NULL);
#define vk_errorf(instance, error, format, ...) __vk_errorf(instance, error, __FILE__, __LINE__, format, ## __VA_ARGS__);
void v3dv_loge(const char *format, ...) v3dv_printflike(1, 2);
void v3dv_loge_v(const char *format, va_list va);
#define v3dv_debug_ignored_stype(sType) \
v3dv_loge("%s: ignored VkStructureType %u:%s\n", __func__, (sType), vk_StructureType_to_str(sType))
fprintf(stderr, "%s: ignored VkStructureType %u:%s\n\n", __func__, (sType), vk_StructureType_to_str(sType))
const struct v3dv_format *v3dv_get_format(VkFormat);
const uint8_t *v3dv_get_format_swizzle(VkFormat f);

20
src/broadcom/vulkan/v3dv_util.c
View File

@ -38,26 +38,6 @@
#include "vk_enum_to_str.h"
#include "v3dv_private.h"
/** Log an error message. */
void v3dv_printflike(1, 2)
v3dv_loge(const char *format, ...)
{
va_list va;
va_start(va, format);
v3dv_loge_v(format, va);
va_end(va);
}
/** \see v3dv_loge() */
void
v3dv_loge_v(const char *format, va_list va)
{
fprintf(stderr, "vk: error: ");
vfprintf(stderr, format, va);
fprintf(stderr, "\n");
}
VkResult
__vk_errorf(struct v3dv_instance *instance, VkResult error, const char *file,
int line, const char *format, ...)