freedreno: Move rsc NULL check to before rsc dereferences.
Fix defect reported by Coverity Scan.
Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking rsc suggests that it may be
null, but it has already been dereferenced on all paths leading
to the check.
Fixes: 6173cc19c4
("freedreno: gallium driver for adreno")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6903>
This commit is contained in:
parent
1b0fec444f
commit
0a7bd14dbb
|
@ -1064,6 +1064,10 @@ fd_resource_from_handle(struct pipe_screen *pscreen,
|
||||||
{
|
{
|
||||||
struct fd_screen *screen = fd_screen(pscreen);
|
struct fd_screen *screen = fd_screen(pscreen);
|
||||||
struct fd_resource *rsc = CALLOC_STRUCT(fd_resource);
|
struct fd_resource *rsc = CALLOC_STRUCT(fd_resource);
|
||||||
|
|
||||||
|
if (!rsc)
|
||||||
|
return NULL;
|
||||||
|
|
||||||
struct fdl_slice *slice = fd_resource_slice(rsc, 0);
|
struct fdl_slice *slice = fd_resource_slice(rsc, 0);
|
||||||
struct pipe_resource *prsc = &rsc->base;
|
struct pipe_resource *prsc = &rsc->base;
|
||||||
|
|
||||||
|
@ -1074,9 +1078,6 @@ fd_resource_from_handle(struct pipe_screen *pscreen,
|
||||||
tmpl->array_size, tmpl->last_level, tmpl->nr_samples,
|
tmpl->array_size, tmpl->last_level, tmpl->nr_samples,
|
||||||
tmpl->usage, tmpl->bind, tmpl->flags);
|
tmpl->usage, tmpl->bind, tmpl->flags);
|
||||||
|
|
||||||
if (!rsc)
|
|
||||||
return NULL;
|
|
||||||
|
|
||||||
*prsc = *tmpl;
|
*prsc = *tmpl;
|
||||||
fd_resource_layout_init(prsc);
|
fd_resource_layout_init(prsc);
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue