KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

panfrost: Z24 variants should be sampled as R32UI 

Midgard has no dedicated samplers for Z24S8 and Z24X8 formats, and the
GPU expects the depth to be encoded in an IEEE 32-bit float. Turn all
Z24_UNORM variants into R32UI and let the shader do the conversion
using bfe+fmul instructions.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3697>
This commit is contained in:
Boris Brezillon 2020-01-31 10:59:23 +01:00 committed by Marge Bot
parent e1ba0cd452
commit 0406ea4856
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/gallium/drivers/panfrost/pan_format.c
View File

@ -186,9 +186,17 @@ panfrost_find_format(const struct util_format_description *desc) {
return MALI_RGB10_A2I;
case PIPE_FORMAT_Z32_UNORM:
return MALI_Z32_UNORM;
case PIPE_FORMAT_Z24X8_UNORM:
case PIPE_FORMAT_Z24_UNORM_S8_UINT:
return MALI_Z32_UNORM;
/* Midgard has no dedicated samplers for Z24S8 and Z24X8
* formats, and the GPU expects the depth to be encoded in an
* IEEE 32-bit float. Turn all Z24_UNORM variants into R32UI
* and let the shader do the conversion using bfe+fmul
* instructions.
*/
return MALI_R32UI;
case PIPE_FORMAT_Z32_FLOAT_S8X24_UINT:
/* Z32F = R32F to the hardware */