KonstantinSeurer
/
mesa
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

intel/validator: validate dst/src types against devinfo support 

v2: deal with src3_a1/src3_a16 instruction types (Curro)

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Francisco Jerez <currojerez@riseup.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16985>
This commit is contained in:
Lionel Landwerlin 2022-06-11 00:23:44 +03:00 committed by Marge Bot
parent 2866ae32da
commit 03e543a422
1 changed files with 51 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
src/intel/compiler/brw_eu_validate.c
View File

@ -716,6 +716,57 @@ general_restrictions_based_on_operand_types(const struct intel_device_info *devi
}
}
enum brw_reg_type dst_type;
if (num_sources == 3) {
if (brw_inst_access_mode(devinfo, inst) == BRW_ALIGN_1)
dst_type = brw_inst_3src_a1_dst_type(devinfo, inst);
else
dst_type = brw_inst_3src_a16_dst_type(devinfo, inst);
} else {
dst_type = inst_dst_type(devinfo, inst);
}
ERROR_IF(dst_type == BRW_REGISTER_TYPE_DF &&
!devinfo->has_64bit_float,
"64-bit float destination, but platform does not support it");
ERROR_IF((dst_type == BRW_REGISTER_TYPE_Q ||
dst_type == BRW_REGISTER_TYPE_UQ) &&
!devinfo->has_64bit_int,
"64-bit int destination, but platform does not support it");
for (unsigned s = 0; s < num_sources; s++) {
enum brw_reg_type src_type;
if (num_sources == 3) {
if (brw_inst_access_mode(devinfo, inst) == BRW_ALIGN_1) {
switch (s) {
case 0: src_type = brw_inst_3src_a1_src0_type(devinfo, inst); break;
case 1: src_type = brw_inst_3src_a1_src1_type(devinfo, inst); break;
case 2: src_type = brw_inst_3src_a1_src2_type(devinfo, inst); break;
default: unreachable("invalid src");
}
} else {
src_type = brw_inst_3src_a16_src_type(devinfo, inst);
}
} else {
switch (s) {
case 0: src_type = brw_inst_src0_type(devinfo, inst); break;
case 1: src_type = brw_inst_src1_type(devinfo, inst); break;
default: unreachable("invalid src");
}
}
ERROR_IF(src_type == BRW_REGISTER_TYPE_DF &&
!devinfo->has_64bit_float,
"64-bit float source, but platform does not support it");
ERROR_IF((src_type == BRW_REGISTER_TYPE_Q ||
src_type == BRW_REGISTER_TYPE_UQ) &&
!devinfo->has_64bit_int,
"64-bit int source, but platform does not support it");
}
if (num_sources == 3)
return error_msg;
@ -741,7 +792,6 @@ general_restrictions_based_on_operand_types(const struct intel_device_info *devi
*/
unsigned dst_stride = STRIDE(brw_inst_dst_hstride(devinfo, inst));
enum brw_reg_type dst_type = inst_dst_type(devinfo, inst);
bool dst_type_is_byte =
inst_dst_type(devinfo, inst) == BRW_REGISTER_TYPE_B ||
inst_dst_type(devinfo, inst) == BRW_REGISTER_TYPE_UB;