From 027c6c12220f802b39d0dac1ab996e451f95bcf5 Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Tue, 26 Apr 2016 02:29:44 -0700 Subject: [PATCH] mesa: Disallow CopyTexSubImage on stencil formats in ES. Fixes - ES31-CTS.gtf.GL31Tests.texture_stencil8.texture_stencil8 - ES31-CTS.gtf.GL31Tests.texture_stencil8.texture_stencil8_multisample Signed-off-by: Kenneth Graunke Reviewed-by: Ian Romanick Reviewed-by: Brian Paul Reviewed-by: Chris Forbes --- src/mesa/main/teximage.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 6ac6fb109d3..76b6584d3bf 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -2530,6 +2530,15 @@ copytexsubimage_error_check(struct gl_context *ctx, GLuint dimensions, } } + /* In the ES 3.2 specification's Table 8.13 (Valid CopyTexImage source + * framebuffer/destination texture base internal format combinations), + * all the entries for stencil are left blank (unsupported). + */ + if (_mesa_is_gles(ctx) && _mesa_is_stencil_format(texImage->_BaseFormat)) { + _mesa_error(ctx, GL_INVALID_OPERATION, "%s(stencil disallowed)", caller); + return GL_TRUE; + } + /* if we get here, the parameters are OK */ return GL_FALSE; }